feat(importing): show all writable calendars in picker #7876
+124
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
odzhychko
commented
Jan 19, 2026
odzhychko
commented
Jan 21, 2026
Mark unsupported calendars as non-selectable. Previously they were fully hidden. Show a message about why some calendars are not selectable. Also show calendars that do not support events (and only support tasks and/or journal entries). Previously, calendars that did not support events were hidden altogether. Resolves: nextcloud#2572 Signed-off-by: Oleksandr Dzhychko <[email protected]>
odzhychko
commented
Jan 25, 2026
| /** | ||
| * List of sorted writable calendars. | ||
| * | ||
| * Even including ones without support for events. |
Author
There was a problem hiding this comment.
This is an interesting case. And I'm not sure if the old behavior was intended or if, respectively, the new behavior is more appropriate.
Because sortedCalendars (and sortedCalendarFilteredByComponents) only returned calendars that at least supported VEVENT users could never import into calendars that only support VTODO or/and VJOURNAL.
odzhychko
commented
Jan 25, 2026
| return calendars | ||
| if (disalbedBecauseOfEvents && disalbedBecauseOfTasks && disalbedBecauseOfJournalEntries) { | ||
| return this.$t('calendar', 'Some calendars are disabled because this file contains events, tasks and journal entries.') |
Author
There was a problem hiding this comment.
Maybe Intl.ListFormat can be used.
See and wait for the outcome of #7875 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark unsupported calendars as non-selectable.
Previously they were fully hidden.
Show a message about why some calendars are not selectable.
Also show calendars that do not support events (and only support tasks and/or journal entries).
Previously, calendars that did not support events were hidden altogether.
Resolves: #2572
Before
After
Test data
SampleIcsFiles.zip
After (previous iterations)
First iteration