fix crash during log sending when exposing URI on Android 7+#372
Merged
AndyScherzinger merged 1 commit intomasterfrom Nov 10, 2016
Merged
fix crash during log sending when exposing URI on Android 7+#372AndyScherzinger merged 1 commit intomasterfrom
AndyScherzinger merged 1 commit intomasterfrom
Conversation
23 tasks
AndyScherzinger
changed the title
Member
Author
|
pushed to beta branch |
AndyScherzinger
force-pushed
the
fixSendLogCrash
branch
3 times, most recently
from
86ad44b to
ad4fe74
Compare
AndyScherzinger
force-pushed
the
fixSendLogCrash
branch
from
ad4fe74 to
73b8220
Compare
tobiasKaminsky
approved these changes
Nov 10, 2016
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as reported in #358 (comment) and reproduced by me, sending the log file crashes the app since from Android 7 on exposing file:// URIs is prohibited.
This PR fixes the issue.
@tobiasKaminsky please review and merge since the master is already targeting Android N 😃