Use correct array of options

[AndyScherzinger]

Resolves: #336

android app crashes when trying to sort a directory of photos to upload

@tobiasKaminsky please review - This is a work in progress since imho the implementation is broken for a simply reason. OCFIleList and LocalFileList both use the same preference for the sorting choice. So if you choose BySize in the main screen and then open upload via the FAB it'll load "by Size" and will try to sort this way. Unfortunately the local file sorting by size also sorts folders, by recursively calculating their size which takes around one minute on my phone... So imho we either need to

• remove folders from the local file sorting as in sort by size with folders on top sorted alphabetically or
• split the sorting choice into two preferences and don't offer sorting by size at all.

What do you think @tobiasKaminsky - I vote for ignore folders during size sorting (locally)

[tobiasKaminsky]

What about a async folder computation which updates the list one after one?

[AndyScherzinger]

That would be an option but seems very expensive as is battery consumption to be able to sort by size including folders and their subfolders. So for local files we could still go for folders first alphabetically and files by size.

What do you think @jancborchardt? Local complete would be nice and consistent but there is a high price to pay for imho.

[AndyScherzinger]

To speed up things for now and fix the bug (crash!), I'd say lets not support sort by size for the local view and fall back to alphabetical sorting in that case.

Agreed?

[jancborchardt]

Sorting method by size is not that crazily important anyway – so if it causes an issue it’s fine to not have it.

[AndyScherzinger]

@tobiasKaminsky ready to review 😃 Sort by size is now also supported in the manual upload view, while folders are sorted alphabetically at the top. Tested on my Nexus5X

[AndyScherzinger]

pushed to beta branch

[tobiasKaminsky]

👍