Move all file type (as in mime type) checks to MimeTypeUtil#323
Merged
AndyScherzinger merged 4 commits intomasterfrom Nov 1, 2016
Merged
Move all file type (as in mime type) checks to MimeTypeUtil#323AndyScherzinger merged 4 commits intomasterfrom
AndyScherzinger merged 4 commits intomasterfrom
Conversation
Member
Sorry - it's currently just overloaded - I will look into proper scale out soon :) |
AndyScherzinger
force-pushed
the
MimeUtilsHousekeeping
branch
3 times, most recently
from
5ada3b1 to
2a941d8
Compare
Member
Author
|
@tobiasKaminsky Imho ready to be merged - please review 🚀 |
AndyScherzinger
force-pushed
the
MimeUtilsHousekeeping
branch
from
2a941d8 to
a529f29
Compare
AndyScherzinger
force-pushed
the
MimeUtilsHousekeeping
branch
from
a529f29 to
a5dec01
Compare
Member
Author
|
@tobiasKaminsky merge? |
tobiasKaminsky
approved these changes
Nov 1, 2016
Member
tobiasKaminsky
left a comment
tobiasKaminsky
left a comment
There was a problem hiding this comment.
Just a really really minor one.
| */ | ||
| public static boolean isImage(String mimeType) { | ||
| return (mimeType.startsWith("image/") && !mimeType.contains("djvu")); | ||
| return (mimeType!=null && mimeType.toLowerCase().startsWith("image/") && !mimeType.toLowerCase().contains |
Member
There was a problem hiding this comment.
space before and after !=
Member
Author
|
And merging 👍 🚀 |
Member
Author
|
lgtm has hickups...again 😡 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #317 [Refactoring] Utilize MimetypeIconUtil implementation
@tobiasKaminsky please review, etc. etc. :)