add grid view option when choosing a file from within the app

[apicellaj]

Implemented a grid view option for choosing a file from the app as mentioned in #185

[AndyScherzinger]

Hi @apicellaj

thank you very much for your PR and welcome to Nextcloud. I did a small test and found two (minor) issues (for code review please see code comments):

• grid/list state information gets lost during screen rotation: switch to grid view and rotate device, the menu still say "grid view" instead of "list view"
• The grid view doesn't use the right layout file and grid width, see screenshot 1, while it should use the one the "regular" file listing view would use, see screenshot 2

Screenshot 1

Screenshot 2

[AndyScherzinger]

getApplicationContext() should be removed

[apicellaj]

Hi @AndyScherzinger

Thanks for the feedback and the warm welcome. The two issues seem to be resolved but let me know if you would like anything changed.

[AndyScherzinger]

@apicellaj thanks for the code changes! 👍

@tobiasKaminsky please have a look, now the grid view for local files would look like this:

--> The local files grid view does distinguish between grid-item and grid-image (image/video) which it can't at the moment since we would have to dynamically detect the mime type. That is possible but we do not have a implementation for that. So I would say it is out of scope and rather open another issue for this matter and declare this one feature complete. What do you think?

[AndyScherzinger]

Slight update, with some customization of the code:

@Override
    public View getView(int position, View convertView, ViewGroup parent) {
        View view = convertView;
        File file = null;
        boolean isGridView = true;
        LayoutInflater inflator = (LayoutInflater) mContext
                .getSystemService(Context.LAYOUT_INFLATER_SERVICE);

        if (mFiles != null && mFiles.length > position && mFiles[position] != null) {
            file = mFiles[position];
        }

        // Find out which layout should be displayed
        ViewType viewType;
        if (parent instanceof GridView) {
            String mimeType = MimetypeIconUtil.getBestMimeTypeByFilename(file.getName());
            if (file != null && (MimetypeIconUtil.isImage(mimeType) || MimetypeIconUtil.isVideo(mimeType))) {
                viewType = ViewType.GRID_IMAGE;
            } else {
                viewType = ViewType.GRID_ITEM;
            }
        } else {
            viewType = ViewType.LIST_ITEM;
            isGridView = false;
        }

        // create view only if differs, otherwise reuse
        if (convertView == null || convertView.getTag() != viewType) {
            switch (viewType) {
                case GRID_IMAGE:
                    view = inflator.inflate(R.layout.grid_image, parent, false);
                    view.setTag(ViewType.GRID_IMAGE);
                    break;
                case GRID_ITEM:
                    view = inflator.inflate(R.layout.grid_item, parent, false);
                    view.setTag(ViewType.GRID_ITEM);
                    break;
                case LIST_ITEM:
                    view = inflator.inflate(R.layout.list_item, parent, false);
                    view.setTag(ViewType.LIST_ITEM);
                    break;
            }
        }

        if (file != null) {
            if(!ViewType.GRID_IMAGE.equals(viewType)) {
                TextView fileName = (TextView) view.findViewById(R.id.Filename);
                String name = file.getName();
                fileName.setText(name);
            }
            ....

leads to this:

@tobiasKaminsky I would apply these changes after we merged this PR since I did some refactorings in the background for MimeType utils and ViewType etc. etc.

[AndyScherzinger]

@tobiasKaminsky what do you think? I'd say merge + another PR later on. 👍

[tobiasKaminsky]

@apicellaj thank you very much for your contribution!

[AndyScherzinger]

Thank you very much for your contribution @apicellaj 🎉 It will be included in the next stable-feature release 🚀

[apicellaj]

Great! Thanks again for your feedback