Crash when sending non-existing log#284
Merged
tobiasKaminsky merged 1 commit intomasterfrom Oct 5, 2016
Merged
Conversation
Member
Author
|
@tobiasKaminsky please review (and merged in case you approve the changes) since this fixes some crashes reported by users |
AndyScherzinger
force-pushed
the
logSendCrash
branch
from
41861a8 to
e67b2a9
Compare
tobiasKaminsky
approved these changes
Sep 26, 2016
Member
Author
|
@tobiasKaminsky also here needs a +1 😉 |
Member
Author
|
Pinging @tobiasKaminsky --> also here needs a +1 😉 |
AndyScherzinger
force-pushed
the
logSendCrash
branch
from
e67b2a9 to
4a774a8
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #283
cc @tobiasKaminsky