fix crash in dismissLoadingDialog #279#281
Merged
tobiasKaminsky merged 2 commits intomasterfrom Oct 5, 2016
Merged
Conversation
AndyScherzinger
force-pushed
the
dismissDialogFragment
branch
from
41fa068 to
e966348
Compare
AndyScherzinger
force-pushed
the
dismissDialogFragment
branch
2 times, most recently
from
0761bff to
200fe5a
Compare
Member
Author
|
@tobiasKaminsky please review (and merged in case you approve the changes) since this fixes some crashes reported in the Play console. |
AndyScherzinger
force-pushed
the
dismissDialogFragment
branch
from
200fe5a to
8281e88
Compare
tobiasKaminsky
approved these changes
Sep 26, 2016
Member
Author
|
@tobiasKaminsky still needs the +1 😉 |
Member
Author
|
Pinging @tobiasKaminsky --> also here needs a +1 😉 |
AndyScherzinger
force-pushed
the
dismissDialogFragment
branch
from
8281e88 to
00684cd
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for details, see #279
tested on Nexus5X, Android N