Skip to content

fix(editor): file opening flow - #17226

Merged
alperozturk96 merged 8 commits into
masterfrom
fix/handle-editor-mimetypes
Jul 23, 2026
Merged

fix(editor): file opening flow#17226
alperozturk96 merged 8 commits into
masterfrom
fix/handle-editor-mimetypes

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Expected flow

# File Downloaded Online Editor Local App Expected Action
1 ✅ Yes ✅ Supported ✅ Available Open with the local app. Also provide an option to open with the online editor.
2 ✅ Yes ✅ Supported ❌ Not Available Open with the online editor.
3 ✅ Yes ❌ Not Supported ✅ Available Open with the local app only.
4 ✅ Yes ❌ Not Supported ❌ Not Available Show an "Unsupported file" message.
5 ❌ No ✅ Supported ✅ Available Open with the online editor. Don't add extra option in file action.
6 ❌ No ✅ Supported ❌ Not Available Open with the online editor. Don't add extra option in file action.
7 ❌ No ❌ Not Supported ✅ Available First download file then open with the local app.
8 ❌ No ❌ Not Supported ❌ Not Available Show an "Unsupported file" message.

New file action

Screenshot_20260717_155821

@alperozturk96 alperozturk96 linked an issue Jun 22, 2026 that may be closed by this pull request
Can't disable opening pdf files on the mobile Nextcloud app #13563
Open
4 tasks
@alperozturk96 alperozturk96 added this to the Nextcloud App 34.0.1 milestone Jun 22, 2026
@alperozturk96

This comment was marked as resolved.

Sign in to view
@alperozturk96
alperozturk96 force-pushed the fix/handle-editor-mimetypes branch from 241a4fc to 076da65 Compare July 8, 2026 08:54
@alperozturk96 alperozturk96 changed the title fix(editor): handle mime types fix(editor): flow Jul 8, 2026
@alperozturk96 alperozturk96 changed the title fix(editor): flow fix(editor): file opening flow Jul 8, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jul 8, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jul 8, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jul 8, 2026
@alperozturk96 alperozturk96 mentioned this pull request Jul 8, 2026
Open
4 tasks
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/28936971082/artifacts/8166009412
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

alperozturk96
alperozturk96 commented Jul 16, 2026
View reviewed changes
Comment thread app/src/main/res/values/strings.xml Outdated
@tobiasKaminsky

This comment was marked as resolved.

Sign in to view
@alperozturk96
alperozturk96 force-pushed the fix/handle-editor-mimetypes branch from 74f3d85 to be03c69 Compare July 17, 2026 13:48
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29585487646/artifacts/8409004178
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the fix/handle-editor-mimetypes branch from a4d5b0b to a597a08 Compare July 22, 2026 07:25
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29900134842/artifacts/8521761588
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the fix/handle-editor-mimetypes branch from a597a08 to 26ffa85 Compare July 22, 2026 09:33
@alperozturk96 alperozturk96 removed a link to an issue Jul 22, 2026
Can't disable opening pdf files on the mobile Nextcloud app #13563
Open
4 tasks
@alperozturk96
alperozturk96 force-pushed the fix/handle-editor-mimetypes branch from 26ffa85 to 6426528 Compare July 22, 2026 09:36
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29908670193/artifacts/8525174919
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the fix/handle-editor-mimetypes branch from 6426528 to 7297eb8 Compare July 22, 2026 12:00
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29917893895/artifacts/8529165190
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix(editor): handle mime types
e581c54 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
c0ed0fc 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/ui/activity/TextEditorWebView.kt
@alperozturk96
fix spotbugs
5b60a58 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix spotbugs
7356e93 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Open in web editor
89f86ef 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Open in web editor
cecde81 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Open in web editor
14377b3 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
ffe71cd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/handle-editor-mimetypes branch from 4997594 to ffe71cd Compare July 22, 2026 13:58
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213208
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4141
Security1919
Total399394

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17226-IT-master-16-36

@alperozturk96
alperozturk96 merged commit 8ce4ef4 into master Jul 23, 2026
19 of 26 checks passed
@alperozturk96
alperozturk96 deleted the fix/handle-editor-mimetypes branch July 23, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky