Skip to content

fix(anr): is auto upload#16585

Merged
alperozturk96 merged 3 commits intomasterfrom
fix/is-auto-upload-anr
Mar 4, 2026
Merged

fix(anr): is auto upload#16585
alperozturk96 merged 3 commits intomasterfrom
fix/is-auto-upload-anr

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 25, 2026

 "main" tid=1 Timed Waiting
  at jdk.internal.misc.Unsafe.park (Native method)
  at java.util.concurrent.locks.LockSupport.parkNanos (LockSupport.java:269)
  at android.database.sqlite.SQLiteConnectionPool.waitForConnection (SQLiteConnectionPool.java:1069)
  at android.database.sqlite.SQLiteConnectionPool.acquireConnection (SQLiteConnectionPool.java:636)
  at android.database.sqlite.SQLiteSession.acquireConnection (SQLiteSession.java:951)
  at android.database.sqlite.SQLiteSession.beginTransactionUnchecked (SQLiteSession.java:332)
  at android.database.sqlite.SQLiteSession.beginTransaction (SQLiteSession.java:311)
  at android.database.sqlite.SQLiteDatabase.beginTransaction (SQLiteDatabase.java:1080)
  at android.database.sqlite.SQLiteDatabase.beginTransaction (SQLiteDatabase.java:1063)
  at android.database.sqlite.SQLiteDatabase.beginTransaction (SQLiteDatabase.java:914)
  at androidx.sqlite.db.framework.FrameworkSQLiteDatabase.beginTransaction (FrameworkSQLiteDatabase.android.kt:52)
  at com.owncloud.android.providers.FileContentProvider.query (FileContentProvider.java:454)
  at android.content.ContentProvider.query (ContentProvider.java:1686)
  at android.content.ContentProvider.query (ContentProvider.java:1782)
  at android.content.ContentProvider$Transport.query (ContentProvider.java:300)
  at android.content.ContentResolver.query (ContentResolver.java:1235)
  at android.content.ContentResolver.query (ContentResolver.java:1167)
  at android.content.ContentResolver.query (ContentResolver.java:1123)
  at com.owncloud.android.datamodel.SyncedFolderProvider.findByRemotePathAndAccount (SyncedFolderProvider.java:443)
  at com.owncloud.android.datamodel.SyncedFolderProvider.isAutoUploadFolder (SyncedFolderProvider.java:88)
  at com.owncloud.android.utils.DisplayUtils.setThumbnailForFolder (DisplayUtils.java:917)
  at com.owncloud.android.utils.DisplayUtils.setThumbnail (DisplayUtils.java:857)
  at com.owncloud.android.utils.DisplayUtils.setThumbnail (DisplayUtils.java:789)
  at com.owncloud.android.ui.adapter.OCFileListDelegate.setThumbnail (OCFileListDelegate.kt:193)
  at com.owncloud.android.ui.adapter.OCFileListDelegate.bindViewHolder (OCFileListDelegate.kt:214)
  at com.owncloud.android.ui.adapter.OCFileListAdapter.bindHolder (OCFileListAdapter.java:479)
  at com.owncloud.android.ui.adapter.OCFileListAdapter.onBindViewHolder (OCFileListAdapter.java:470)
  at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder (RecyclerView.java:7747)
  at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder (RecyclerView.java:7847)
  at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline (RecyclerView.java:6646)
  at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline (RecyclerView.java:6917)
  at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition (RecyclerView.java:6757)
  at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition (RecyclerView.java:6753)
  at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next (LinearLayoutManager.java:2362)
  at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk (LinearLayoutManager.java:1662)

isAutoUpload call causing ANR on main thread with this PR we are checking from memory and updating the value from background.

@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.36

@alperozturk96 alperozturk96 force-pushed the fix/is-auto-upload-anr branch 3 times, most recently from 3908b64 to 51b2d36 Compare February 27, 2026 07:23
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/datamodel/SyncedFolderProvider.java
#	app/src/main/java/com/owncloud/android/utils/DisplayUtils.java
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/is-auto-upload-anr branch from 51b2d36 to 9e8367c Compare March 4, 2026 10:22
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 4, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7575
Dodgy code253252
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4343
Security1818
Total475474

@alperozturk96 alperozturk96 merged commit 19b97e8 into master Mar 4, 2026
15 of 20 checks passed
@alperozturk96 alperozturk96 deleted the fix/is-auto-upload-anr branch March 4, 2026 10:30
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16585.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants