fix(auto-upload): show notification only when conditions are met #16282
+18
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk96 <[email protected]>
alperozturk96
force-pushed
the
fix/show-notification-only-if-conditions-are-met-for-auto-upload
branch
from
f5f393f to
7993447
Compare
alperozturk96
commented
Jan 13, 2026
| return getForegroundInfo(notification) | ||
| } | ||
|
|
||
| fun getForegroundInfo(notification: Notification): ForegroundInfo = |
Collaborator
Author
There was a problem hiding this comment.
Since this is needed for other workers, we can move this logic to the WorkerNotificationManager
Collaborator
Author
|
/backport to stable-3.35 |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
ZetaTom
approved these changes
Jan 14, 2026
Collaborator
ZetaTom
left a comment
ZetaTom
left a comment
There was a problem hiding this comment.
Tested on AOSP Android 11 using a Pixel 2 emulator. Works while app is in foreground and background.
alperozturk96
deleted the
fix/show-notification-only-if-conditions-are-met-for-auto-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
trySetForeground()called before ensuring conditions, this causing to see multiple notifications. Conditions need to be checked first.