Merged
Conversation
halmamol
approved these changes
Dec 16, 2025
Contributor
halmamol
left a comment
halmamol
left a comment
There was a problem hiding this comment.
This PR corrects the wrong distance between TP diceboards caused by several changes on geometry reviews. Now the pitch between SiPMs is consistent (15.55mm), the sensor plane is centered in (0,0) and numbers match correctly with the engineer drawings. Good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The difference in sipm x-positions between adjacent dices was not the same as within a board (15.55 mm). The geometry was previously tweaked in #170 and #219, but somewhere along the way we forgot to ensure the distances were correct.