fix: replace curl HEAD with GET request for proxy compatibility in RHEL recipe#1321
Draft
fix: replace curl HEAD with GET request for proxy compatibility in RHEL recipe#1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infrastructure agent installation fails on RHEL/CentOS 7+ systems when using HTTP proxies, with the error:
there is no newrelic infrastructure agent available for the distribution '7'.Root Cause
The recipe's prerequisite check here uses
curl -Is(HEAD request) to verify the availability of the New Relic repository:curl -Is {{.NEW_RELIC_DOWNLOAD_URL}}infrastructure_agent/linux/yum/el/{{.DISTRO_VERSION}}/x86_64/newrelic-infra.repoIssue
Many corporate proxies block or mishandle HEAD requests, causing this check to fail even though:
Solution
Changed the curl command to use a GET request instead:
curl -s -o /dev/null -w "%{http_code}" {{.NEW_RELIC_DOWNLOAD_URL}}infrastructure_agent/linux/yum/el/{{.DISTRO_VERSION}}/x86_64/newrelic-infra.repo### Changes:
✅ GET requests are universally supported by corporate proxies
✅ More reliable HTTP status code parsing
✅ No functional change - still validates repository availability
✅ Maintains backward compatibility with non-proxy environments