[WIP] use g_fork_execvp instead of g_fork #2598
Draft
unstabler wants to merge 15 commits intoneutrinolabs:develfrom
Draft
[WIP] use g_fork_execvp instead of g_fork #2598unstabler wants to merge 15 commits intoneutrinolabs:develfrom
unstabler wants to merge 15 commits intoneutrinolabs:develfrom
Conversation
…for child_arguments
…ystem instead TODO: implement log_restart_from(int log_fd, ...)
Member
|
Hi @unstabler This is going along the right lines, and for the reasons you state regarding MacOS, we need to get this functionality in one way or another. There's a couple of things you haven't considered which will need to be included in a complete solution:-
I'm currently focussed on getting sesman split into two for xrdp v1.x. This will mean I'm going to need to cover all of the above in sesman anyway, so I suggest we hold off on this one until I've got that done. I've probably missed a few things, and we'll find those during testing. Regarding your existing code, you can simplify things by ditching the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
fork().fork().CHANGES
g_fork_execvp(exec, argv)has addedg_get_executable_path(exectype, buf, bufsize)has addedxrdpnow accepts--child-processand--child-fd [fd], entrypoint for child process also addedxrdpwill useg_fork_execvp()instead ofg_fork()for accepting new connectionsTODO
logger->fdto child process (via argv, or ...), as i reconstructedstruct trans?xrdp_listen.c:814...struct xrdp_process *,struct trans *afterxrdp_process_main_looptranslated from:
ですが、かなりコアなコードが修正されたのに、改善される事項は上記の一つしかいないと思うので、もし必要にならないと思われた場合は気楽にこのPRをクローズしても結構です。