Skip to content

🧪 [testing improvement] Cover JSON exceptions and missing files in ProjectComposer #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmuench merged 1 commit into from
Mar 23, 2026
Merged

🧪 [testing improvement] Cover JSON exceptions and missing files in ProjectComposer #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/N98/Util/ProjectComposer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,14 @@ public function isComposerJsonFile()
*/
public function getComposerLockPackages()
{
$lockFilePath = $this->getComposerLockPath();
if (!file_exists($lockFilePath)) {
return [];
}

try {
$composerLockContent = json_decode(
file_get_contents($this->getComposerLockPath()),
file_get_contents($lockFilePath),
true,
512,
JSON_THROW_ON_ERROR
Expand Down
40 changes: 40 additions & 0 deletions tests/N98/Util/ProjectComposerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

namespace N98\Util;

use org\bovigo\vfs\vfsStream;
use PHPUnit\Framework\TestCase;

class ProjectComposerTest extends TestCase
Expand Down Expand Up @@ -62,4 +63,43 @@ public function itShouldReturnEmptyArrayIfLockFileIsMalformed()
$this->assertIsArray($returnedPackages);
$this->assertEmpty($returnedPackages);
}

/**
* @test
*/
public function itShouldReturnEmptyArrayIfLockFileDoesNotExist()
{
vfsStream::setup('root');
$projectComposer = new ProjectComposer(vfsStream::url('root'));
$returnedPackages = $projectComposer->getComposerLockPackages();

$this->assertIsArray($returnedPackages);
$this->assertEmpty($returnedPackages);
}

/**
* @test
*/
public function itShouldReturnEmptyArrayIfLockFileContainsInvalidJson()
{
vfsStream::setup('root', null, ['composer.lock' => '{invalid}']);
$projectComposer = new ProjectComposer(vfsStream::url('root'));
$returnedPackages = $projectComposer->getComposerLockPackages();

$this->assertIsArray($returnedPackages);
$this->assertEmpty($returnedPackages);
}

/**
* @test
*/
public function itShouldHandleMissingPackagesKeys()
{
vfsStream::setup('root', null, ['composer.lock' => '{}']);
$projectComposer = new ProjectComposer(vfsStream::url('root'));
$returnedPackages = $projectComposer->getComposerLockPackages();

$this->assertIsArray($returnedPackages);
$this->assertEmpty($returnedPackages);
}
}