Skip to content

common/common.c: compareprocname(): Linux /proc/X/exe pseudo-symlink can end with "(deleted)"… #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimklimov merged 1 commit into from
Jul 17, 2025
Merged

common/common.c: compareprocname(): Linux /proc/X/exe pseudo-symlink can end with "(deleted)"… #3021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions common/common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
# include <psapi.h>
#endif /* WIN32 */

#include "nut_platform.h"

#ifdef HAVE_UNISTD_H
# include <unistd.h> /* readlink */
#endif
Expand Down Expand Up @@ -1345,6 +1347,9 @@ int compareprocname(pid_t pid, const char *procname, const char *progname)
/* Track where the last dot is in the basename; 0 means none */
size_t procbasenamedot = 0, progbasenamedot = 0;
char procbasename[NUT_PATH_MAX + 1], progbasename[NUT_PATH_MAX + 1];
#ifdef NUT_PLATFORM_LINUX
char *s = NULL;
#endif

if (checkprocname_ignored(__func__)) {
ret = -3;
Expand Down Expand Up @@ -1403,6 +1408,30 @@ int compareprocname(pid_t pid, const char *procname, const char *progname)
}
#endif /* WIN32 */

#ifdef NUT_PLATFORM_LINUX
/* According to https://stackoverflow.com/a/58105245/4715872
* the Linux kernel function d_path() (convert a dentry into
* an ASCII path name) can report if the original file was
* deleted since the process started.
*/
if ((s = strstr(procname, " (deleted)")) != NULL && s[10] == '\0') {
char pntmp[NUT_PATH_MAX + 1];
int restmp;

strncpy(pntmp, procname, sizeof(pntmp) - 1);
pntmp[s - procname] = '\0';

upsdebugx(2, "%s: re-evaluate the substring without a special tail: '%s'=>'%s'",
__func__, procname, pntmp);
restmp = compareprocname(pid, pntmp, progname);
if (restmp <= 0)
return restmp;

ret = 6;
goto finish;
}
#endif /* LINUX */

/* TOTHINK: Developer builds wrapped with libtool may be prefixed
* by "lt-" in the filename. Should we re-enter (or wrap around)
* this search with a set of variants with/without the prefix on
Expand All @@ -1414,6 +1443,15 @@ int compareprocname(pid_t pid, const char *procname, const char *progname)

finish:
switch (ret) {
case 6:
upsdebugx(1,
"%s: original program file of running "
"PID %" PRIuMAX " named '%s' was removed "
"or replaced, but matches our '%s'",
__func__, (uintmax_t)pid,
procname, progname);
break;

case 5:
upsdebugx(1,
"%s: case-insensitive base name hit with "
Expand Down