snmp-ups: debug when static entries are skipped; fix ups.test.date in apc-mib to be semi-static#3012
Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom Jul 11, 2025
Merged
Conversation
… to SU_FLAG_SEMI_STATIC [networkupstools#3011] Signed-off-by: Jim Klimov <[email protected]>
…STATIC entries [networkupstools#3011] Signed-off-by: Jim Klimov <[email protected]>
Member
Author
|
Change seems reasonable anyway, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3011
Wondering if
upsdebugx(1, ...)verbosity level used to report activity on other entry flags would be too "loud" with skipped statics?..@sirmeili: would you have a chance to test this fix? See e.g. https://github.com/networkupstools/nut/wiki/Building-NUT-for-in%E2%80%90place-upgrades-or-non%E2%80%90disruptive-tests about building custom NUT from sources (using this PR's source branch in my fork, if it is not merged by then). You would probably need to leave the driver running, get a last
ups.test.dateat that time, initiate a test and wait for up tosemistaticfreq(default 10) update cycles or so to see if the new date value gets reported.