Fix #206 CMP AL, 4 by modifying x86/preinsns.pl to include reg_al in arithmetic instruction …#208
Open
RMarx1456 wants to merge 1 commit intonetwide-assembler:masterfrom
Open
Fix #206 CMP AL, 4 by modifying x86/preinsns.pl to include reg_al in arithmetic instruction …#208RMarx1456 wants to merge 1 commit intonetwide-assembler:masterfrom
RMarx1456 wants to merge 1 commit intonetwide-assembler:masterfrom
Conversation
RMarx1456
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #206 originally referenced the instruction cmp al, 4 not assembling to the two-byte binary instruction, as shown in the comparison in the issue. The instructions
add, or, adc, sbb, and, sub, xorwere also affected by the error.In commit f0dc7c2 the change to x86/preinsns.pl didn't include the pattern for
reg_alimmediate encoding, which resulted in every immediate encoded instruction usingalin the arithmetic pattern not being placed in the compiled insns files offinsns.dat.The debugging information added to
itemplatestructure in fbacd59 assisted me directly in finding the root cause of this issue, as I was able to quickly find the discrepancy between insns.xda made from the current GitHub version compared to a previous version (I used v3.01). Thank you for adding that information.Due to the issue being in preinsns.pl, the issue was also present when disassembling the bytes
3C04from issue #206 using the current github version, which is also fixed now. When disassembled, the output gave two define byte pseudo-ops (db 3C, db 04).Thank you for reading this pull request, and let me know if you need any changes made or such.