Fnn cli by 15168316096 · Pull Request #28 · nervosnetwork/fiber-py-integration-test

15168316096 · 2026-02-25T14:47:48Z

Fnn cli test

Merge pull request #15 from gpBlockchain/oneway_channel

Copilot

Pull request overview

Adds a Python test harness for the new fnn-cli binary (plus list_payments RPC) and expands devnet integration coverage for trampoline routing and one-way channels.

Changes:

Add framework/fnn_cli.py wrapper to run fnn-cli and parse JSON/YAML output.
Add devnet test suites for fnn-cli (info/peer/channel/invoice/payment/graph) and list_payments RPC behavior.
Extend trampoline routing + one-way channel integration tests and update prepare.sh to copy fnn-cli artifacts.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test_cases/fiber/devnet/trampoline_routing/test_allowTramponlieRouting.py	Refactors/expands trampoline routing scenarios (success + failure cases, extra sync helpers).
test_cases/fiber/devnet/one_way/test_oneway_channel.py	Adds more one-way channel behavior tests (directionality, restart, shutdown edge cases).
test_cases/fiber/devnet/fnn-cli/test_list_payments_rpc.py	Adds RPC-level tests for `list_payments` filtering/pagination/consistency.
test_cases/fiber/devnet/fnn-cli/test_cli_peer.py	Adds CLI peer command tests.
test_cases/fiber/devnet/fnn-cli/test_cli_payment.py	Adds CLI payment + list_payments tests (including dry-run).
test_cases/fiber/devnet/fnn-cli/test_cli_output_format.py	Adds CLI output format validation tests (json/yaml/raw).
test_cases/fiber/devnet/fnn-cli/test_cli_invoice.py	Adds CLI invoice lifecycle tests.
test_cases/fiber/devnet/fnn-cli/test_cli_info.py	Adds CLI node_info parity tests vs RPC.
test_cases/fiber/devnet/fnn-cli/test_cli_graph.py	Adds CLI graph query tests and parity checks vs RPC.
test_cases/fiber/devnet/fnn-cli/test_cli_channel.py	Adds CLI channel lifecycle tests.
test_cases/fiber/devnet/accept_channel/test_accept_channel.py	Removes an old commented-out/placeholder file.
prepare.sh	Copies `fnn-cli` debug/release binaries into `download/fiber/current/`.
framework/fnn_cli.py	New `FnnCli` subprocess wrapper used by the new CLI tests.
framework/fiber_rpc.py	Adds `list_payments` RPC method wrapper.
.github/workflows/fiber-fnn-cli.yml	New CI workflow to build fiber + run `fnn-cli`-focused test groups.
.cursor/skills/fiber-test/**	Adds internal reference docs for test patterns / concepts / API notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-25T14:54:07Z

+        str_map = {
+            "enabled": "--enabled",
+            "tlc_expiry_delta": "--tlc-expiry-delta",
+            "tlc_minimum_value": "--tlc-minimum-value",


update_channel() uses kwarg key tlc_minimum_value, but open_channel()/accept_channel() use tlc_min_value. This inconsistency makes the wrapper API error-prone (a caller passing tlc_min_value will be silently ignored). Consider standardizing on tlc_min_value (and optionally supporting tlc_minimum_value as a backward-compatible alias).

Suggested change

str_map = {

"enabled": "--enabled",

"tlc_expiry_delta": "--tlc-expiry-delta",

"tlc_minimum_value": "--tlc-minimum-value",

# Normalize legacy/alias kwarg name for minimum TLC value

if "tlc_minimum_value" in kwargs and "tlc_min_value" not in kwargs:

kwargs["tlc_min_value"] = kwargs["tlc_minimum_value"]

del kwargs["tlc_minimum_value"]

str_map = {

"enabled": "--enabled",

"tlc_expiry_delta": "--tlc-expiry-delta",

"tlc_min_value": "--tlc-min-value",

Copilot · 2026-02-25T14:54:07Z

+            pytest.xfail(
+                "pending fix: receiver should validate preimage using invoice hash_algorithm "
+                f"(sha256), error={str(e)}"
+            )


pytest.xfail() is triggered for any exception from wait_payment_state(), which can mask unrelated infra/test flakiness (timeouts, connectivity, topology issues) as an expected failure. It would be safer to only xfail when the caught error matches the known sha256/hash_algorithm validation issue, and re-raise otherwise (or use a conditional @pytest.mark.xfail with a strict reason).

Suggested change

pytest.xfail(

"pending fix: receiver should validate preimage using invoice hash_algorithm "

f"(sha256), error={str(e)}"

)

error_msg = str(e).lower()

if "hash_algorithm" in error_msg or "sha256" in error_msg:

pytest.xfail(

"pending fix: receiver should validate preimage using invoice hash_algorithm "

f"(sha256), error={str(e)}"

)

raise

Copilot · 2026-02-25T14:54:08Z

+        time.sleep(20)
+
+        channels_after = cli1.list_channels(include_closed=True)
+        found = False
+        for ch in channels_after["channels"]:
+            if ch["channel_id"] == channel_id:
+                found = True
+                assert "CLOSED" in ch["state"]["state_name"] or ch["state"][
+                    "state_name"
+                ] in ["SHUTTING_DOWN", "CLOSED"]


Using a fixed time.sleep(20) after shutdown_channel makes this test both slow and potentially flaky (close can legitimately take longer/shorter). Prefer waiting on a concrete condition (e.g., poll list_channels(include_closed=True) until the target channel_id reaches SHUTTING_DOWN/CLOSED, or use the existing wait_for_channel_state(..., include_closed=True, channel_id=...)).

Suggested change

time.sleep(20)

channels_after = cli1.list_channels(include_closed=True)

found = False

for ch in channels_after["channels"]:

if ch["channel_id"] == channel_id:

found = True

assert "CLOSED" in ch["state"]["state_name"] or ch["state"][

"state_name"

] in ["SHUTTING_DOWN", "CLOSED"]

# Wait until the channel is observed in a terminal state instead of using a fixed sleep.

deadline = time.time() + 60

found = False

while time.time() < deadline and not found:

channels_after = cli1.list_channels(include_closed=True)

for ch in channels_after["channels"]:

if ch["channel_id"] == channel_id:

state_name = ch["state"]["state_name"]

if state_name in ["SHUTTING_DOWN", "CLOSED"] or "CLOSED" in state_name:

found = True

break

if not found:

time.sleep(1)

gpBlockchain · 2026-03-03T07:56:11Z

@@ -0,0 +1,268 @@
+name: fnn-cli test
+


Why not add it directly to fiber test.yml?

gpBlockchain · 2026-03-03T07:56:25Z

@@ -0,0 +1,181 @@
+# Fiber RPC API Reference


need upgrade

gpBlockchain · 2026-03-03T08:52:01Z

 cd fiber
 cargo build
 cp target/debug/fnn ../download/fiber/current/fnn.debug
+cp target/debug/fnn-cli ../download/fiber/current/fnn-cli.debug


Suggested change

cp target/debug/fnn-cli ../download/fiber/current/fnn-cli.debug

…tegration-test into fnn-cli

* Initial plan * Update fnn-cli and tests for peer_id → pubkey migration per issue #29 Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com>

15168316096 and others added 13 commits January 20, 2026 16:57

Merge pull request #16 from gpBlockchain/main

1e5e959

Merge pull request #15 from gpBlockchain/oneway_channel

send payment failed if oneway

872974d

del test_accept_channel.py

b603e2c

formate code

67b994d

add p0 testcases for trampoline

9242c47

update test_trampoline_invoice_success cases

9d33b10

wait dev fix

95117b2

add p0 p1 case

a4d51fd

add algo invoice

bb12b85

trampoline_hops Vec<pubkey>

7b9539d

add fiber test skills

b71e23e

add fiber skills

b032807

add fnn-cli testcases

c54c56e

15168316096 requested review from Copilot and gpBlockchain February 25, 2026 14:47

Copilot started reviewing on behalf of 15168316096 February 25, 2026 14:48 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

15168316096 and others added 2 commits February 26, 2026 10:27

add test_list_payments_rpc.py

24242ab

Merge branch 'main' into fnn-cli

c066f61

gpBlockchain reviewed Mar 3, 2026

View reviewed changes

15168316096 and others added 5 commits March 12, 2026 14:50

adapt fnn-cli auth

09c1ee4

Merge branch 'fnn-cli' of https://github.com/gpBlockchain/fiber-py-in…

377e7cd

…tegration-test into fnn-cli

format code by black

5d89f98

format framework/fnn_cli

a411ad8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fnn cli#28

Fnn cli#28
15168316096 wants to merge 20 commits intomainfrom
fnn-cli

15168316096 commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

gpBlockchain Mar 3, 2026

Uh oh!

gpBlockchain Mar 3, 2026

Uh oh!

gpBlockchain Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

15168316096 commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

gpBlockchain Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

gpBlockchain Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

gpBlockchain Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants