Reforcor code#19
Open
gpBlockchain wants to merge 34 commits intooneway_channelfrom
Open
Conversation
- 测试方法 docstring 必须列出 Step 1、Step 2、… - 方法体内代码严格按 Step 分段，每段以 # Step N: 对应 - 在 10.3/10.4、第 4 步、总结与示例中统一强调 - 示例补充 test_case2、test_boundary、test_payment_with_assertions 的 Step 说明
…n and assertions for various channel states. Ensure proper rejection messages for abandoning channels in signed, ready, shutting down, and closed states. Refactor test structure for clarity and consistency.
…for channel abandonment scenarios. Ensure clarity in test structure and enhance rejection message handling for various channel states.
… documentation for channel abandonment scenarios. Improve assertions and rejection message handling across various channel states.
…for querying existing and non-existent invoices. Refactor test structure to follow step-by-step format, improving clarity and consistency in test cases.
… complete in the todo list, enhance documentation and assertions in `test_list_channels`, `test_currency`, `test_amount`, `test_mutil_sig`, and `test_list_peers`. Refactor tests to follow a step-by-step format for clarity and consistency, ensuring proper handling of expected outcomes and error messages.
…omplete in the todo list, improve documentation and assertions for various parameters including description, expiry, final_expiry_delta, fallback_address, and hash_algorithm. Streamline test structure to follow a step-by-step format, ensuring clarity and consistency in handling expected outcomes and error messages.
…n the todo list, improve documentation and assertions for various scenarios including funding amounts, payment methods, and channel states. Refactor tests to follow a structured step-by-step format, ensuring clarity and consistency in expected outcomes and error handling.
…s to ensure clarity and consistency. Emphasize the requirement for all code and comments to be written in English, and provide detailed examples for proper documentation practices. Refactor existing test case docstrings and comments to align with these standards, improving overall readability and understanding.
…complete in the todo list, improve documentation and assertions for various scenarios including funding amounts, timeout behavior, and channel states. Streamline test structure to follow a step-by-step format, ensuring clarity and consistency in expected outcomes and error handling.
…omplete in the todo list, improve documentation and assertions for various scenarios including UDT and CKB channels, hash algorithms, and revocation transactions. Streamline test structure to follow a step-by-step format, ensuring clarity and consistency in expected outcomes and error handling.
…d assertions for tlc_fee_proportional_millionths, tlc_min_value, and tlc_expiry_delta parameters. Streamline test structure to follow a step-by-step format, ensuring clarity and consistency in expected outcomes and error handling. Remove deprecated tests related to tlc_max_value and improve overall readability.
…d assertions for various scenarios including mixed payment with CKB and UDT, atomic MPP multi-path payments, and payment handling during channel shutdown. Streamline test structure to follow a step-by-step format, ensuring clarity and consistency in expected outcomes and error handling. Mark multiple tests as complete in the todo list.
…ons for multi-path payment scenarios, including self-payments, peer disconnect handling, and force shutdown behavior. Streamline test structure to follow a step-by-step format, ensuring clarity and consistency in expected outcomes and error handling. Mark multiple tests as complete in the todo list.
…tions for various scenarios including private channels, multi-hop payments, error handling, and fee rate tests. Streamline test structure to follow a step-by-step format, ensuring clarity and consistency in expected outcomes and error messages. Mark multiple tests as complete in the todo list.
…ions across multiple test files, including Wasm demo, multi-instance, RPC, and connect peer tests. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark tests as complete in the todo list.
…s across multiple test files, including tests for channel ID validation, enabled flag behavior, TLC fee proportional millionths, and expiry delta. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark multiple tests as complete in the todo list.
…d assertions for various scenarios including handling payments during node stops and restarts, both graceful and forceful. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark multiple tests as complete in the todo list.
…for various parameters including max_fee_amount, final_tlc_expiry_delta, and hop_hints. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark multiple tests as complete in the todo list.
…tation and assertions to use UDT instead of CKB for account generation in various scenarios. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark multiple tests as complete in the todo list.
…d assertions across multiple test files, including handling used preimages, multiple channel payments, and invoice creation. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark additional tests as complete in the todo list.
…t assertion to improve test reliability. Update documentation for clarity on test behavior.
…d assertions across multiple test files, focusing on pending TLC handling during mid-node shutdowns. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark additional tests as complete in the todo list.
…n and assertions for channel_id, fee_rate, and close_script parameters. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark multiple tests as complete in the todo list.
…ons for various parameters including channel_id, fee_rate, close_script, and force shutdown scenarios. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark additional tests as complete in the todo list.
…ons for shutdown scenarios involving node restarts, including both initiator and acceptor. Streamline test structures to follow a clear step-by-step format, ensuring consistency in expected outcomes and error handling. Mark additional tests as complete in the todo list.
…ons to ensure proper handling of UDT in account generation scenarios. Streamline test structures for consistency and clarity in expected outcomes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.