Add screenshot capture to evaluation pipeline#646
Open
keugenek wants to merge 2 commits intoneondatabase:mainfrom
Open
Add screenshot capture to evaluation pipeline#646keugenek wants to merge 2 commits intoneondatabase:mainfrom
keugenek wants to merge 2 commits intoneondatabase:mainfrom
Conversation
- Add capture_screenshot() function that runs Playwright in Dagger - Starts app as service, takes screenshot, exports to host - Call screenshot capture after runtime succeeds in evaluation
- Add capture_screenshot_local() using async Playwright API - Reorder evaluation: capture screenshot right after runtime check (before tests which may kill the app) - Add capture_screenshot() for Dagger pipeline - Update start prompt to not kill app after health check - Add playwright as dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code