[N4] Adapt neo-node to Neo 4.0.0#989
Open
ajara87 wants to merge 63 commits intoneo-project:masterfrom
Open
Conversation
Merged
This was referenced Feb 5, 2026
Merged
Member
|
UT still fault |
Member
Author
Its a draft. Still working on it |
…-node into adapt-neo-node-neo-4
Contributor
|
This PR is too large, and it can only modify the parts that cause compilation errors. |
…-node into adapt-neo-node-neo-4
Contributor
|
Any progress? |
Member
Author
working on It. Its just 8 tests to fix and it's ready |
shargon
reviewed
Mar 21, 2026
shargon
reviewed
Mar 22, 2026
Comment on lines
81
to
82
| if (_enabledTrackers.Contains("NEP-11")) | ||
| trackers.Add(new Nep11Tracker(_db, _maxResults, _shouldTrackHistory, neoSystem)); |
Member
There was a problem hiding this comment.
Why NEP11 is working and Nep17 removed?
I think both should be removed
Member
Author
There was a problem hiding this comment.
I can remove it in a different PR. Nep17 had to remove them within this PR because its tests were failing and to avoid removing it they would have had to be adapted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the master branch to reflect the changes made in Neo 4.0.0
Related to #988