fix(WalletAPI): sleep between WaitTransaction retries on RPC errors - #1102
Open
cschuchardt88 wants to merge 4 commits into
Open
fix(WalletAPI): sleep between WaitTransaction retries on RPC errors#1102cschuchardt88 wants to merge 4 commits into
cschuchardt88 wants to merge 4 commits into
Conversation
GetRawTransaction failures were swallowed with an empty catch and no delay, so a missing tx or persistent RPC error busy-looped until timeout.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-n3 #1102 +/- ##
=============================================
+ Coverage 51.48% 51.52% +0.04%
=============================================
Files 284 284
Lines 16699 16703 +4
Branches 2148 2148
=============================================
+ Hits 8598 8607 +9
+ Misses 7527 7522 -5
Partials 574 574 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vncoelho
approved these changes
Aug 30, 2026
shargon
reviewed
Aug 31, 2026
| { | ||
| // Unknown tx and transient RPC errors retry until timeout; | ||
| // sleep so a persistent failure cannot busy-loop the CPU. | ||
| await Task.Delay(pollDelay).ConfigureAwait(false); |
Member
There was a problem hiding this comment.
use finally and do it only once?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WaitTransactionAsyncswallowedGetRawTransactionfailures with an empty catch and no delay. A missing transaction or persistent RPC error busy-looped the CPU until timeout.Sleep on both unknown-tx and exception paths, with a 100ms floor, and retry until the tx has confirmations.
Independent of other PRs. RpcClient helper only; not consensus-critical.