Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
7a9ef7f to
2f10a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This is required to be able to do
uv pip install -e .and create an editable install.It modernizes the
pyproject.tomlfile according to the following primer:See https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#modernize-setup-py-project
NOTE: This is a "minimal" modernization to make us standards-compliant and get things working with
uv. Moving all non-programmatic metadata (e.g. project name, author, etc.) fromsetup.pytopyproject.tomlis recommended, and we could pursue this at some point.How has this been tested?
Installed it locally and it works.
How long should this take to review?
Types of changes:
Checklist:
Still to do: