feat(#1461): filter JMS properties by route area#2407
Open
jneidel wants to merge 3 commits intonelmio:4.xfrom
Open
feat(#1461): filter JMS properties by route area#2407jneidel wants to merge 3 commits intonelmio:4.xfrom
jneidel wants to merge 3 commits intonelmio:4.xfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #2407 +/- ##
==========================================
+ Coverage 89.50% 89.51% +0.01%
==========================================
Files 78 78
Lines 2896 2910 +14
==========================================
+ Hits 2592 2605 +13
- Misses 304 305 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jneidel
commented
Dec 9, 2024
DjordyKoert
requested changes
Mar 7, 2025
|
|
||
| $area = $model->getArea(); | ||
| if (null !== $area) { | ||
| $context->addExclusionStrategy(new VersionExclusionStrategy($area)); |
Collaborator
There was a problem hiding this comment.
Could you write a test? 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the area configured in the route (like
/api/{area}/doc/) to filter out properties on the model, which should be excluded based on JMS's versioning (also see demo below.)Closes #1461
Refs #2129
What type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)Demo from our project
We have an entity property:
Opening the docs on the route:
/api/v4.3/doc/,which is configured as:
before this PR


after this PR
Implementation
I opted for the word "area", since it is used in the route definition.
I proceeded as adviced in #1461.
Could you point me to where you would like to see tests created/adjusted?