Jlc/add cms support for admin and course creator by johanseto · Pull Request #2 · nelc/eox-nelp

johanseto · 2022-08-19T20:12:34Z

Description

This is related to the requirement of Nelp that is creating users but need to give course creator permissions.
The problem is that until the user login, the user will not appear in the course-creator table.
https://github.com/eduNEXT/edx-platform/blob/master/cms/djangoapps/contentstore/views/course.py#L1889-L1893
So this PR adds the option to add course creator directly from the admin model matching with the username of the user model.
Development
This is a remake of eduNEXT/edx-platform#269 using the eox-nelpplugin.
Configuration
Remember to configure you have to update your cms/env/devstack.py or your custom settings.

FEATURES['ENABLE_CREATOR_GROUP'] = True.
Note: Is already in stage environment to check.
https://studio.stage.nelp.gov.sa/admin/course_creators/coursecreator/add/

Jira story

https://edunext.atlassian.net/browse/NELP-195?atlOrigin=eyJpIjoiNmFmOTc4YTk4NDczNGZiZGEwZjA2YzY5MjdlYzljNjQiLCJwIjoiaiJ9

Before

After

This allow modify the course creator model admin using the eox-nelp plugin. This change add the possibilty to add or delete course creator from admin.

Due course_creators is an studio app, when lms use `eox_nelp` it bring an error. This avoid the following error ```RuntimeError: Model class cms.djangoapps.course_creators.models.CourseCreator doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS```. So you have to add this one in the `INSTALLED_APPS`.

andrey-canon · 2022-08-19T21:43:28Z

eox_nelp/edxapp_wrapper/backends/course_creators_l_v1.py

@@ -0,0 +1,23 @@
+"""Backend for course_creators module.


the convention is file_name_{first letter of the version}_v1.py so for this case this should be course_creators_k_v1.py

Actually, I put lilac cause is like a reference. Most of the eox-core backends don't have the koa version, and instead, use the lilac. That is the reason I set Lilac.

They didn't test eox-core with koa so I think that is the reason. Anyway you can not ensure that this backend will work in lilac therefore you should set the name with the version that you use

OK, you have a good point. Let me change it.

Changed in 71e8c18

andrey-canon · 2022-08-19T21:45:13Z

eox_nelp/admin/course_creators.py

+    def has_add_permission(self, request):
+        return True
+    def has_delete_permission(self, request, obj=None):
+        return True


Suggested change

def has_add_permission(self, request):

return True

def has_delete_permission(self, request, obj=None):

return True

def has_add_permission(self, request):

return True

def has_delete_permission(self, request, obj=None):

return True

Resolved in a125a75

andrey-canon · 2022-08-19T21:46:44Z

eox_nelp/admin/course_creators.py

+classes:
+    nelpCourseCreatorAdmin: EoxNelp CourseCreators admin class.
+"""
+from __future__ import absolute_import


generally we use this in applications that has support for python 2 and 3, this is just for python 3 so do you need this for something else ?

No, I think no cause we are using python3, I will remove it.

Resolved in a125a75

andrey-canon · 2022-08-19T21:47:20Z

eox_nelp/edxapp_wrapper/course_creators.py

+This contains all the required dependencies from course_creators.
+Attributes:
+    backend:Imported ccx module by using the plugin settings.
+    CourseCreator: Wrapper courseCreator model.


Suggested change

CourseCreator: Wrapper courseCreator model.

CourseCreator: Wrapper CourseCreator model.

Resolved in a125a75

andrey-canon · 2022-08-19T21:47:45Z

eox_nelp/edxapp_wrapper/course_creators.py

+"""Wrapper course_creator module file.
+This contains all the required dependencies from course_creators.
+Attributes:
+    backend:Imported ccx module by using the plugin settings.


Resolved in a125a75

andrey-canon · 2022-08-19T21:48:31Z

eox_nelp/apps.py

+class EoxNelpCMSConfig(AppConfig):
+    """App configuration"""
+    name = 'eox_nelp'
+    verbose_name = "eduNEXT Openedx Extensions"


I'm not sure about this

@andrey-canon what is the problem? THe name???

this could be Nelp Openedx Extension since "eduNEXT Openedx Extensions" is eox-core

Ah ok heheh let me I change it.

Resolved in a125a75

andrey-canon · 2022-08-19T21:50:26Z

eox_nelp/admin/course_creators.py

+
+
+class NelpCourseCreatorAdmin(CourseCreatorAdmin):
+    """EoxSupport CertificateTemplate admin class.


EoxSupport? CertificateTemplate ?

Resolved in a125a75

andrey-canon · 2022-08-19T21:50:41Z

eox_nelp/admin/course_creators.py

@@ -0,0 +1,36 @@
+"""courseCreators admin file.


Suggested change

"""courseCreators admin file.

"""CourseCreators admin file.

Resolved in a125a75

andrey-canon · 2022-08-19T21:50:59Z

eox_nelp/admin/course_creators.py

+"""courseCreators admin file.
+Contains all the nelped admin models for course_creators.
+classes:
+    nelpCourseCreatorAdmin: EoxNelp CourseCreators admin class.


Suggested change

nelpCourseCreatorAdmin: EoxNelp CourseCreators admin class.

NelpCourseCreatorAdmin: EoxNelp CourseCreators admin class.

Resolved in a125a75

Due this backend was backend was tested in koa it could add uncertainty affirm that would work in lilac too.

johanseto force-pushed the jlc/add-cms-support-for-admin-and-course-creator branch from fb9517d to 3600012 Compare August 19, 2022 20:15

johanseto added 3 commits August 19, 2022 16:01

feat: add course creator option admin by eox nelp

9322fd4

This allow modify the course creator model admin using the eox-nelp plugin. This change add the possibilty to add or delete course creator from admin.

refactor: separate the CMS config

2ddf854

johanseto force-pushed the jlc/add-cms-support-for-admin-and-course-creator branch from f98aeb6 to edd5ed2 Compare August 19, 2022 21:01

johanseto requested a review from andrey-canon August 19, 2022 21:39

andrey-canon requested changes Aug 19, 2022

View reviewed changes

johanseto added 2 commits August 19, 2022 17:12

style: apply code suggestions from review

a125a75

refactor: change course-creator backend to koa

71e8c18

Due this backend was backend was tested in koa it could add uncertainty affirm that would work in lilac too.

johanseto requested a review from andrey-canon August 19, 2022 22:32

andrey-canon approved these changes Aug 19, 2022

View reviewed changes

johanseto merged commit b623854 into master Aug 22, 2022

	CourseCreator: Wrapper courseCreator model.
	CourseCreator: Wrapper CourseCreator model.



		class NelpCourseCreatorAdmin(CourseCreatorAdmin):
		"""EoxSupport CertificateTemplate admin class.

	nelpCourseCreatorAdmin: EoxNelp CourseCreators admin class.
	NelpCourseCreatorAdmin: EoxNelp CourseCreators admin class.

Conversation

johanseto commented Aug 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Jira story

Before

After

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

johanseto commented Aug 19, 2022 •

edited

Loading