Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cca0fb1:
|
|
Size change: +0.78 kB
View unchanged
|
Extend ImageLoader functionality to be able to work with image sources containing headers We preserve the existing strategy that works with image.src for cases where source is just an uri with no headers When sources contain headers we make a fetch request and then render a local url for the downloaded blob (URL.createObjectURL) Fix #1019 Fix #2268 Close #2442
If the Image component is rendered with a `null` source, and consecutively updated with actual source url that was already loaded, it would fail to pick up the change - `state` would be `IDLE` for a brief moment and this would cause a small flicker when the image renders Let's always start from IDLE state, and update `shouldDisplaySource` condition to be based on `ImageLoader.has` cache or not Fix #2492
1 task
|
I would like to use the preview in my application as I would love to take advantage of the Image http headers. I'll admit im not well versed in git... how would I reference this instead of 0.19? 0.20-dev doesnt appear to change anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.20 will be focused on the "Image" milestone: https://github.com/necolas/react-native-web/milestone/18
Notes
StyleSheet runtime for compilers
babel-plugin-react-native-webhas a new optionlegacy, which istrueby default. Set it tofalseand the plugin will no longer rewrite any'react-native'paths, with the exception of theStyleSheetimport.The
StyleSheetimport is rewritten to[..]/StyleSheet/runtime.The runtime is only
StyleSheet()withoutcreate,compose,flatten, etc., support.The
legacy:falseoption should be used only if a built-time compiler is being used to extract styles to CSS, and either inline results or error the otherStyleSheetmethod calls React Native includes. The compiler output should follow the style object format described by the styleq runtime.This is an experiment to add a mechanism to exclude the runtime style compiler from builds. It's open to feedback and iteration.
Changelog
New features