`near transaction construct-transaction` is limited to maximum of 3 actions

[mitinarseny]

Hey Team!
Awesome CLI, absolutely love it! Would it be hard to add support for adding more than 3 actions to a single batch transaction? So it can be useful for flows like: create account -> deploy -> call init() -> call acl_revoke_super_admin() -> ...

$ near transaction construct-transaction abc.near abc.near \
  add-action function-call first  json-args '{}' prepaid-gas '1.0 Tgas' attached-deposit '0 NEAR' \
  add-action function-call second json-args '{}' prepaid-gas '1.0 Tgas' attached-deposit '0 NEAR' \
  add-action function-call third  json-args '{}' prepaid-gas '1.0 Tgas' attached-deposit '0 NEAR' \
  add-action #function-call forth json-args '{}' prepaid-gas '1.0 Tgas' attached-deposit '0 NEAR'

error: unexpected argument 'add-action' found

Usage: near transaction construct-transaction add-action function-call prepaid-gas attached-deposit add-action function-call prepaid-gas attached-deposit add-action function-call prepaid-gas attached-deposit [DEPOSIT] [COMMAND]

For more information, try '--help'.

The problem seems to be connected with interactive_clap limitations:

near-cli-rs/src/commands/transaction/construct_transaction/add_action_last/mod.rs

Lines 3 to 11 in 98960d5

	#[derive(Debug, Clone, EnumDiscriminants, interactive_clap::InteractiveClap)]
	#[interactive_clap(context = super::ConstructTransactionContext)]
	#[strum_discriminants(derive(EnumMessage, EnumIter))]
	/// Select an action that you want to add to the action:
	pub enum NextAction {
	#[strum_discriminants(strum(message = "skip - Skip adding a new action"))]
	/// Go to transaction signing
	Skip(super::skip_action::SkipAction),
	}

[frol]

@mitinarseny Thank you for raising it. There is unfortunately a limitation of the currently used clap implementation. Adding more nesting slows down CLI start up time for all the commands as clap tries to resolve the whole tree of nested commands. We had to limit the number of actions to 3. We will need to implement a generic solution on clap side: clap-rs/clap#2222 (comment)

I can only suggest to use near-api-js or near-api-rs to construct such transactions

[frol]

Once the PR to clap (clap-rs/clap#6225) will land and released, we can try to raise the limit to 10 or something like that. It would still require this ugly copy-paste code (maybe we can just create a script that would replicate the _1 to 10 more copies).

[mitinarseny]

It would still require this ugly copy-paste code (maybe we can just create a script that would replicate the _1 to 10 more copies).

Or leverage macro_rules!?

[frol]

Or leverage macro_rules!?

That would be really hard to maintain since it requires quite a bit of code to be macro-generated, and if all of that code will be inside the macro rule, IDEs will likely go crazy.