Skip to content

chore(contract): remove DomainConfigCompat and CurveCompat#2771

Draft
kevindeforth wants to merge 3 commits intomainfrom
kd/contract-remove-domain-compat
Draft

chore(contract): remove DomainConfigCompat and CurveCompat#2771
kevindeforth wants to merge 3 commits intomainfrom
kd/contract-remove-domain-compat

Conversation

@kevindeforth
Copy link
Copy Markdown
Contributor

@kevindeforth kevindeforth commented Apr 9, 2026

resolves #2770

stacked on #2763

gilcu3
gilcu3 previously approved these changes Apr 9, 2026
Copy link
Copy Markdown
Contributor

@gilcu3 gilcu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,5 +1,6 @@
---
source: crates/contract/tests/abi.rs
assertion_line: 47
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets skip this line

@gilcu3
Copy link
Copy Markdown
Contributor

gilcu3 commented Apr 9, 2026

LGTM

But many tests failed, so I should have written a conditional LGTM :D

@gilcu3 gilcu3 self-requested a review April 9, 2026 07:48
Base automatically changed from 2757-clean-up-migration-only-code-after-v38-deployment to main April 9, 2026 10:28
@gilcu3 gilcu3 dismissed their stale review April 9, 2026 10:28

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants