Skip to content

fix: witness should not inherit serde traits#2748

Open
SimonRastikian wants to merge 1 commit intosimon/assert-no-panicfrom
simon/witness-deserialization
Open

fix: witness should not inherit serde traits#2748
SimonRastikian wants to merge 1 commit intosimon/assert-no-panicfrom
simon/witness-deserialization

Conversation

@SimonRastikian
Copy link
Copy Markdown
Contributor

@SimonRastikian SimonRastikian commented Apr 8, 2026

Closes #2747

@SimonRastikian SimonRastikian changed the base branch from main to simon/assert-no-panic April 8, 2026 09:53
@SimonRastikian SimonRastikian self-assigned this Apr 8, 2026
@claude
Copy link
Copy Markdown

claude bot commented Apr 8, 2026

Code Review: fix: witness should not inherit serde traits

Clean, focused security improvement. Removing Serialize/Deserialize from Witness<C> prevents accidental serialization of private scalar material. The struct already correctly implements Zeroize + Drop, and no existing code depends on serde for this type.

✅ Approved — no critical issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilcu3 gilcu3 gilcu3 approved these changes

@netrome netrome netrome approved these changes

Assignees

@SimonRastikian SimonRastikian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Witness should not inherit serde traits to prevent leakage

3 participants

@SimonRastikian @gilcu3 @netrome