fix: assert in crypto layer replaced by proper error handling#2746
Open
SimonRastikian wants to merge 3 commits intosimon/getting-rid-of-indexing-slicingfrom
Open
fix: assert in crypto layer replaced by proper error handling#2746SimonRastikian wants to merge 3 commits intosimon/getting-rid-of-indexing-slicingfrom
SimonRastikian wants to merge 3 commits intosimon/getting-rid-of-indexing-slicingfrom
Conversation
SimonRastikian
changed the base branch from
main
to
simon/getting-rid-of-indexing-slicing
gilcu3
requested changes
Apr 8, 2026
Contributor
gilcu3
left a comment
gilcu3
left a comment
There was a problem hiding this comment.
Minor change requested, as the current code will accepts what was previously rejected. If it is too cumbersome to use Errors there, it is strictly better to leave the asserts, unless we are convinced these were not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2745