MOAB Skinner updated to take arbitrary fields rather than just temperature and density. - #1422
MOAB Skinner updated to take arbitrary fields rather than just temperature and density. #1422makeclean wants to merge 9 commits into
Conversation
|
Thanks @makeclean! This looks neat - I will take a look this week! For the test suite to launch, can you go accept the invite to join the |
|
I activated the tests on Civet. Precheck failed with Tests should activate automatically going forward after you accept the cardinal-devs invitation |
meltawila
left a comment
There was a problem hiding this comment.
Thank you for the PR. these are a few initial comments until the test suite runs
Could you re-invite - I think it may've expired can't seem to find it |
|
@makeclean I just re-sent the invite, let me know if it doesn't show up |
|
Job Precheck, step Clang format on 034c621 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
|
Job Documentation, step Sync to remote on b77d9ad wanted to post the following: View the site here This comment will be updated on new commits. |
- Add check in OpenMCCellAverageProblem::initialSetup() that every field binned by the skinner corresponds to configured temperature or density feedback - Update density_skin/cannot_skin_solid test to match new error message
|
Ok, this is looking better tests are passing, however I'm seeing a failure from something I've not touched, |
Thank you. yes, NekRS tests failures are not related to this PR and are being addressed separately |
This change allows for the MOAB skinner to skin on arbitrary fields rather than just temperature and density. I have a use case for which I would like to skin on some other quantity and this felt like the most appropriate change.
Its quite a large PR and happy to take comments. I guess I consider this a draft for now, until I've done more testing.