Skip to content

MOAB Skinner updated to take arbitrary fields rather than just temperature and density. - #1422

Open
makeclean wants to merge 9 commits into
neams-th-coe:develfrom
makeclean:moab_skins
Open

MOAB Skinner updated to take arbitrary fields rather than just temperature and density. #1422
makeclean wants to merge 9 commits into
neams-th-coe:develfrom
makeclean:moab_skins

Conversation

@makeclean

Copy link
Copy Markdown

This change allows for the MOAB skinner to skin on arbitrary fields rather than just temperature and density. I have a use case for which I would like to skin on some other quantity and this felt like the most appropriate change.

Its quite a large PR and happy to take comments. I guess I consider this a draft for now, until I've done more testing.

@aprilnovak

Copy link
Copy Markdown
Collaborator

Thanks @makeclean! This looks neat - I will take a look this week! For the test suite to launch, can you go accept the invite to join the cardinal-devs organization and then force-push to update?

@meltawila

Copy link
Copy Markdown
Member

I activated the tests on Civet. Precheck failed with

ERROR: The following files do not contain a newline character before EOF:
	test/tests/userobjects/moab_skinner/three_fields.i

Run the "delete_trailing_whitespace.sh" script in your $MOOSE_DIR/scripts directory.
##########################################################################

[14:43:12] ERROR: Exiting with code 1

Tests should activate automatically going forward after you accept the cardinal-devs invitation

@meltawila meltawila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. these are a few initial comments until the test suite runs

Comment thread test/tests/neutronics/filters/energy/#mesh_energy_array.i# Outdated
Comment thread src/userobjects/MoabSkinner.C Outdated
Comment thread src/userobjects/MoabSkinner.C Outdated
Comment thread src/userobjects/MoabSkinner.C Outdated
Comment thread test/tests/neutronics/dagmc/density_skin/only_solid.i Outdated
Comment thread test/tests/neutronics/dagmc/density_skin/openmc.i Outdated
@makeclean

Copy link
Copy Markdown
Author

Thanks @makeclean! This looks neat - I will take a look this week! For the test suite to launch, can you go accept the invite to join the cardinal-devs organization and then force-push to update?

Could you re-invite - I think it may've expired can't seem to find it

@aprilnovak

Copy link
Copy Markdown
Collaborator

@makeclean I just re-sent the invite, let me know if it doesn't show up

@moosebuild

Copy link
Copy Markdown
Collaborator

Job Precheck, step Clang format on 034c621 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/1422/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format f8c22a8c5d1f119f2237ac2d01dc5f2f3a7ecc08

@moosebuild

moosebuild commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Job Documentation, step Sync to remote on b77d9ad wanted to post the following:

View the site here

This comment will be updated on new commits.

- Add check in OpenMCCellAverageProblem::initialSetup() that every field
  binned by the skinner corresponds to configured temperature or density
  feedback
- Update density_skin/cannot_skin_solid test to match new error message
@makeclean

Copy link
Copy Markdown
Author

Ok, this is looking better tests are passing, however I'm seeing a failure from something I've not touched,

--------------------------------------------------------------------------------------------------------------
[92.30s] [1240MB]     DIFF userobjects/gap/nondimensional.nondim FAILED (EXODIFF) [FINISHED,slots=2]```
Is this a known failure or should I start digging deeper?

@meltawila

Copy link
Copy Markdown
Member

Ok, this is looking better tests are passing, however I'm seeing a failure from something I've not touched,

Thank you. yes, NekRS tests failures are not related to this PR and are being addressed separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants