Closed
Conversation
Mortality rate was decreased from 0.5 to 0.4 since more hosts are now dying because of rounding up which in turn causes less spread. The new value keeps the spread on a similar levels, although the values are of course different. Tests test_sei_treatments_removal_ratio_to_all and test_sei_treatments_pesticide_ratio_to_all have same values for individual outputs at year 2021 because the simple and pesticide treatments are now more similar before one used floor and the other ceil.
Member
Author
|
This needs to have ncsu-landscape-dynamics/pops-core#218 merged to update the submodule. |
Member
Author
|
Replaced by PRs for individual changes to track the changes better. The values here are not useful anymore because they don't reflect the finished rounding code, only its initial version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mortality rate was decreased from 0.5 to 0.4 since more hosts are now dying because of rounding up which in turn causes less spread. The new value keeps the spread on a similar levels, although the values are of course different.
Tests test_sei_treatments_removal_ratio_to_all and test_sei_treatments_pesticide_ratio_to_all have same values for individual outputs at year 2021 because the simple and pesticide treatments are now more similar before one used floor and the other ceil.