Explicitly disable mortality in host pool#231
Merged
wenzeslaus merged 2 commits intomainfrom Jun 16, 2025
Merged
Conversation
Instead of relying on size of the mortality vector, ignore the provided data completely when mortality is explicitly disabled. This povides greater flexibility on what rpops and Rcpp can do (#230). Besides adding yet another config value to the HostPool, add also a constructor which takes a Config object, so that all values can be taken from there. Switch to that in Model and tests when HostPool is used directly, but keep using the old, but updated constructor in tests which don't use config and in Simulation because the Simulation and its tests are not using Config.
Member
|
Once this is done I can review it, and then can we merge it with PR #225 as I need both at once in order to test if this indeed fixes the issue of treatments not applying with those changes. |
ChrisJones687
approved these changes
Jun 16, 2025
Member
ChrisJones687
left a comment
ChrisJones687
left a comment
There was a problem hiding this comment.
This all looks good. Once merged we will need to make the same change in PR #225 current line number 569.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on size of the mortality vector, ignore the provided data completely when mortality is explicitly disabled. This povides greater flexibility on what rpops and Rcpp can do (#230).
Besides adding yet another config value to the HostPool, add also a constructor which takes a Config object, so that all values can be taken from there. Switch to that in Model and tests when HostPool is used directly, but keep using the old, but updated constructor in tests which don't use config and in Simulation because the Simulation and its tests are not using Config.