INTERNAL: Override equals and hashCode in core classes#886
Merged
jhpark816 merged 1 commit intonaver:developfrom Apr 4, 2025
Merged
Conversation
namsic
changed the title
oliviarla
previously approved these changes
Mar 31, 2025
Collaborator
|
@uhm0311 최종 리뷰 바랍니다. |
uhm0311
previously approved these changes
Mar 31, 2025
jhpark816
reviewed
Mar 31, 2025
jhpark816
reviewed
Mar 31, 2025
Jinyshin
force-pushed
the
refactor/override-equals-hashcode-#630
branch
from
f4d12ed to
62842ac
Compare
oliviarla
reviewed
Apr 4, 2025
| return false; | ||
| } | ||
|
|
||
| Element<?> element = (Element<?>) o; |
Collaborator
There was a problem hiding this comment.
여기도 변수명을 that으로 두면 좋겠습니다.
Jinyshin
force-pushed
the
refactor/override-equals-hashcode-#630
branch
from
62842ac to
aa7047c
Compare
oliviarla
previously approved these changes
Apr 4, 2025
jhpark816
reviewed
Apr 4, 2025
Collaborator
jhpark816
left a comment
jhpark816
left a comment
There was a problem hiding this comment.
리뷰 완료
사소한 것 하나가 있습니다.
| public CollectionOperationStatus getCollectionResponse() { | ||
| return opStatus; | ||
| } | ||
|
|
Jinyshin
force-pushed
the
refactor/override-equals-hashcode-#630
branch
from
aa7047c to
59975db
Compare
jhpark816
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
equals()와hashCode()메서드를 오버라이드하여 ArcusClient API에서 제공하는 객체들의 비교 연산을 개선했습니다.OperationStatus와CollectionOperationStatus에equals()및hashCode()를 추가하여 객체 비교를 지원하도록 변경했습니다.Element,BKeyObject,ByteArrayBKey클래스에equals()와hashCode()를 오버라이드하여 동등성 비교가 가능하도록 수정했습니다.SMGetElement,SMGetTrimKey,BTreeGetResult클래스에equals()와hashCode()를 추가하여 컬렉션(Set, Map)에서 key로 활용할 수 있도록 개선했습니다.==(참조 비교)가 사용되어 같은 데이터를 갖고 있어도 다른 객체로 인식되던 문제를 해결했습니다.