INTERNAL: Remove cancelNoneIdempotent arg in MoveOperationTask#878
Merged
jhpark816 merged 1 commit intonaver:developfrom Feb 19, 2025
Merged
INTERNAL: Remove cancelNoneIdempotent arg in MoveOperationTask#878jhpark816 merged 1 commit intonaver:developfrom
jhpark816 merged 1 commit intonaver:developfrom
Conversation
uhm0311
reviewed
Feb 18, 2025
uhm0311
approved these changes
Feb 18, 2025
Collaborator
|
@oliviarla 추가 리뷰어 지정합니다. |
oliviarla
approved these changes
Feb 19, 2025
Collaborator
|
다음과 같은 이유로 적합하다고 판단했습니다. 잘못 이해한 부분이 있다면 알려주세요. (MoveOperationTask는 updateReplConnections 메서드 내부에서만 호출되므로 zk 로부터 응답이 왔다는 것을 전제로 함)
|
jhpark816
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
https://github.com/jam2in/arcus-works/issues/686
⌨️ What I did
MoveOperationTask 생성자에서 사용되는 cancelNonIdempotent를 제거한다.
이후 MoveOperationTask 내부에서는 true 값을 통해
무조건 non-idempotent 연산은 cancel 하도록 한다.
기존에 해당 값이 false로 설정된 로직들은 아래와 같다.
그 외는 아래 코멘트에 적힌 버그입니다.
https://github.com/jam2in/arcus-works/issues/686#issuecomment-2646920539