INTERNAL: add option to disable optimization in CollectionTranscoder#877
Merged
jhpark816 merged 1 commit intonaver:developfrom Feb 19, 2025
Merged
INTERNAL: add option to disable optimization in CollectionTranscoder#877jhpark816 merged 1 commit intonaver:developfrom
jhpark816 merged 1 commit intonaver:developfrom
Conversation
uhm0311
reviewed
Feb 18, 2025
src/test/manual/net/spy/memcached/collection/transcoder/CollectionTranscoderTest.java
Show resolved
Hide resolved
uhm0311
previously approved these changes
Feb 18, 2025
jhpark816
reviewed
Feb 18, 2025
| @Override | ||
| public CachedData encode(Object o) { | ||
| if (!optimize) { | ||
| return new CachedData(SERIALIZED, serialize(o), getMaxSize()); |
Collaborator
There was a problem hiding this comment.
플래그를 설정해 두는 것이 좋을 것 같습니다.
flags |= SERIALIZED;decode 할 시에는
optimize 설정 값이 아닌
flags 값에 따라서 deserialize() 수행하는 것이 맞을 것 같습니다.
jhpark816
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did