Skip to content

Comments

CLEANUP: remove or modify methods in command classes#876

Merged
jhpark816 merged 1 commit intonaver:developfrom
oliviarla:cleanup
Feb 17, 2025
Merged

CLEANUP: remove or modify methods in command classes#876
jhpark816 merged 1 commit intonaver:developfrom
oliviarla:cleanup

Conversation

@oliviarla
Copy link
Collaborator

🔗 Related Issue

⌨️ What I did

  • 명령 객체의 생성자에서 값을 검증하도록 하고 getter를 제거했습니다.
  • 객체 내부에서만 사용되는 public 메서드를 private 메서드로 변경했습니다.

@oliviarla oliviarla requested a review from jhpark816 February 17, 2025 02:07
@oliviarla oliviarla self-assigned this Feb 17, 2025
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

return str;
}

private String getSpaceSeparatedMkeys() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MapGet.java 파일에서도 동일하게 수정이 필요합니다.

@jhpark816 jhpark816 merged commit 44a453a into naver:develop Feb 17, 2025
2 checks passed
@oliviarla oliviarla deleted the cleanup branch April 29, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants