INTERNAL: Limit bulk get keys size#847
Closed
cheesecrust wants to merge 1 commit intonaver:developfrom
Closed
Conversation
oliviarla
reviewed
Dec 6, 2024
Collaborator
oliviarla
left a comment
oliviarla
left a comment
There was a problem hiding this comment.
가능하다면 테스트코드도 추가해주면 좋겠습니다.
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Outdated
Show resolved
Hide resolved
cheesecrust
force-pushed
the
internal/optimize
branch
from
ace1f23 to
f25bea7
Compare
Contributor
Author
진행하겠습니다. |
jhpark816
reviewed
Dec 6, 2024
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Show resolved
Hide resolved
cheesecrust
force-pushed
the
internal/optimize
branch
from
f25bea7 to
a6c9cb1
Compare
cheesecrust
force-pushed
the
internal/optimize
branch
from
a6c9cb1 to
b559ee2
Compare
Collaborator
|
@cheesecrust 리뷰 모두 반영된 상태인가요? |
Contributor
Author
리뷰와 테스트 코드는 반영한 상태입니다. |
oliviarla
reviewed
Dec 16, 2024
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Show resolved
Hide resolved
cheesecrust
force-pushed
the
internal/optimize
branch
2 times, most recently
from
71a76b0 to
58edd42
Compare
cheesecrust
force-pushed
the
internal/optimize
branch
from
58edd42 to
bc3ebe4
Compare
oliviarla
reviewed
Dec 27, 2024
src/main/java/net/spy/memcached/protocol/ascii/AsciiMemcachedNodeImpl.java
Show resolved
Hide resolved
cheesecrust
force-pushed
the
internal/optimize
branch
from
bc3ebe4 to
5fc310c
Compare
oliviarla
approved these changes
Dec 31, 2024
Contributor
Author
|
#858 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
asyncGetBulk의 연산의 키 제한 개수와 같게 200개의 제한을 두었습니다.이를 하나만 있어도 되도록 변경했습니다.(optimized 를 사용하기 위해 get이 두개 이상 연속 되었는지 판단 할 필요 사라짐)