FIX: Split piped operations into single-key and multi-key to resolve bug during migration#1029
Merged
jhpark816 merged 1 commit intonaver:developfrom Dec 15, 2025
Merged
Conversation
…bug during migration
Collaborator
|
@uhm0311 |
Collaborator
Author
|
추가했습니다. |
oliviarla
reviewed
Dec 12, 2025
src/main/java/net/spy/memcached/protocol/ascii/MultiKeyPipeOperationImpl.java
Show resolved
Hide resolved
oliviarla
reviewed
Dec 12, 2025
src/main/java/net/spy/memcached/protocol/ascii/SingleKeyPipeOperationImpl.java
Show resolved
Hide resolved
oliviarla
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
Integer index대신String key를 넘깁니다.구체적인 변경 사항은 다음과 같습니다.
Operation 클래스
String key필드와SingleKeyPipedOperationCabllack cb필드를 갖고 있습니다.List<String> keys필드와MultiKeyPipedOperationCabllack cb필드를 갖고 있습니다.OperationCallback 클래스
gotStatus(Integer index, OperationStatus status))을 그대로 수행하되, 이름을 SingleKeyOperationCallback으로 변경합니다.gotStatus(String key, OperationStatus status)로직을 수행하는 OperationCallback 인터페이스입니다.