Isolate registry verifier tests from fork metadata - #4715
Open
xxxxxx-oss wants to merge 1 commit into
Open
Conversation
The registry verifier fixtures model artifacts published by nautechsystems/nautilus_trader. GitHub Actions supplies a fork repository through GITHUB_REPOSITORY, which makes the production identity checks reject the fixed fixture data. Pin the repository identity inside run_verifier so the test harness is independent of its caller while production verification remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make format, then ranmake pre-commitlocally and confirmed it passedRELEASES.mdSummary
Pin the official repository identity inside the published-registry test fixture so GitHub Actions running in a fork cannot leak its
GITHUB_REPOSITORYvalue into the fixture. This keeps the fixed crates.io and PyPI publisher data internally consistent while leaving production provenance verification unchanged.Related issues/PRs
None.
Type of change
Breaking change details (if applicable)
Not applicable.
Documentation
make py-stubs(not applicable)Testing
Validated locally with:
bash -n scripts/ci/test-verify-published-registries-crates.bashGITHUB_REPOSITORYvaluesshfmt,shellcheck, trailing-whitespace, and diff checksFull
make test-scriptson macOS stops before this test in the unchangedtest-publish-wheels.bashorphan-deletion assertion (Failed orphan deletion left a stale index link). The affected registry test passes independently. Fullmake formatandmake pre-commitwere not run locally because of local resource constraints; the file-scoped hooks relevant to this Bash-only change passed.