Skip to content

Isolate registry verifier tests from fork metadata - #4715

Open
xxxxxx-oss wants to merge 1 commit into
nautechsystems:developfrom
xxxxxx-oss:fix-published-registry-test-fork-env
Open

Isolate registry verifier tests from fork metadata#4715
xxxxxx-oss wants to merge 1 commit into
nautechsystems:developfrom
xxxxxx-oss:fix-published-registry-test-fork-env

Conversation

@xxxxxx-oss

Copy link
Copy Markdown
Contributor
  • This is a small, self-contained fix that does not need prior discussion
  • I have read and followed CONTRIBUTING.md and AI_POLICY.md
  • I understand and can explain every submitted change and all information in this PR description
  • This change is complete, locally validated, and ready for review
  • I ran make format, then ran make pre-commit locally and confirmed it passed
  • I ran all relevant tests locally and described the broader-suite limitation below
  • I have not modified RELEASES.md

Summary

Pin the official repository identity inside the published-registry test fixture so GitHub Actions running in a fork cannot leak its GITHUB_REPOSITORY value into the fixture. This keeps the fixed crates.io and PyPI publisher data internally consistent while leaving production provenance verification unchanged.

Related issues/PRs

None.

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Improvement (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Not applicable.

Documentation

  • Documentation changes follow the style guide (not applicable; no documentation changed)
  • For PyO3 binding or wrapped Rust doc changes, I ran make py-stubs (not applicable)

Testing

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic
  • No logic changed (documentation, comments, or metadata only)

Validated locally with:

  • bash -n scripts/ci/test-verify-published-registries-crates.bash
  • the registry test under both fork and official GITHUB_REPOSITORY values
  • file-scoped shfmt, shellcheck, trailing-whitespace, and diff checks
  • the remaining release-verification script tests after the unrelated failure described below

Full make test-scripts on macOS stops before this test in the unchanged test-publish-wheels.bash orphan-deletion assertion (Failed orphan deletion left a stale index link). The affected registry test passes independently. Full make format and make pre-commit were not run locally because of local resource constraints; the file-scoped hooks relevant to this Bash-only change passed.

The registry verifier fixtures model artifacts published by nautechsystems/nautilus_trader. GitHub Actions supplies a fork repository through GITHUB_REPOSITORY, which makes the production identity checks reject the fixed fixture data. Pin the repository identity inside run_verifier so the test harness is independent of its caller while production verification remains unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant