Show more filetypes in "Download files" sidebar - #244
Merged
Conversation
megannissel
commented
Jul 31, 2026
| labels = { | ||
| 'csv': 'CSV', | ||
| 'geojson': 'GeoJSON', | ||
| 'tif': 'GeoTIFF', |
Contributor
Author
There was a problem hiding this comment.
I alphabetized these lists while I was here, to make them a bit easier to scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jesse and I noticed yesterday that the PDF README for the Colombia 3Ps package wasn't listed in the dataset's "Download files" sidebar. Jesse then also noticed .xlsx and .html files included in that package aren't listed, either.
When we have a package like 3Ps Colombia, there are only two Resources: the top-level
.zip.ymland the top-level.zip. What files are listed in the sidebar depends upon the dataset'ssourceslist and theshown_extensionslist inhelpers.py. I've expanded this list (as well as two lists we use for labels in various places) to include.pdf,.html,.xlsx, and.gpkg(because I noticed this one was also missing), which should address the problem. Also added icons for.htmland.gpkg, as we didn't have those before.I don't love that we essentially have three lists with similar-but-subtly-different functionality; this feels like a less than ideal pattern for long-term maintenance. We may want to consider reworking this logic in the future. But for now, this should address the immediate concern.