9160 Socket Network Support

[dboling-ericsson]

Description

Adds non-secure network support for nrf9160.

Motivation and Context

Feature add

How Has This Been Tested?

Limited testing with HttpSample

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dev Containers (changes related with Dev Containers, has no impact on code or features)
• Dependencies (update dependencies and changes associated, has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

[dboling-ericsson]

Style changes look good.

[Ellerbach]

Thanks for the addition, that will be useful! Few comments more on the style. Please don't forget to merge the latest code style PR into your branch. In general, we don't keep dead code or we document why it's there. And we don't keep the traces. Also, in some of the code, it would be great to have few more comments to understand what's done and for some of the key functions a good description of what they are doing. In general, that does help a lot for the maintenance.

[Ellerbach]

if you comment this line of code, please add a little comment on why :-)

[dboling-ericsson]

Sorry for the sloppy code. I wanted to post what I could as I'm not sure when I'll be able to work on the code again. I'll try to clean things up today.

[dboling-ericsson]

The 'build failing' bug is strange. I always build the code before uploading. I'm trying now, to build and have the build pull down the NCS instead of referencing a local copy. If that fails, I'll know what the issue is.

[dboling-ericsson]

I pushed up a fix to the build error. It was a problem with the ARDESCO target not having the proper configuration. In my rush, I hadn't built that version before posting. Fixed and tested all 3 targets.

[josesimoes]

I pushed up a fix to the build error. It was a problem with the ARDESCO target not having the proper configuration. In my rush, I hadn't built that version before posting. Fixed and tested all 3 targets.

Awesome! Thanks for fixing it.

[josesimoes]

@dboling-ericsson I've started reviewing this.
It's a lot of code and I wanted to test it thoroughly.
Just wanted to give you a note that this is not forgotten and it's highly appreciated. 😃

[dboling-ericsson]

Great to hear. I don't have as much time for this now but am happy to answer questions and to fix something if I can.