Option to prevent rationale dialog from being cancelled by the user - #27
Open
jepschmidt wants to merge 2 commits into
Open
Option to prevent rationale dialog from being cancelled by the user#27jepschmidt wants to merge 2 commits into
jepschmidt wants to merge 2 commits into
Conversation
* Set the rationale dialog cancelable / not cancelable. * Set rationale dialog custom negative button text. * Set rationale dialog custom positive button text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I had a scenario in my App, where the user would keep getting the rationale dialog over and over again for each attempt to run a specific action that required a certain permission (if denied). When the user hit "cancel" in the rationale dialog, neither the system nor the Android-Permissions library would keep any persisted record of the denial. Thus I needed to force the user to continue to the system permission request dialog, so that the system could mark the permission as permanently denied (when denied again), and automatically respond with denial for any further requests.
For this I introduced an option to control whether or not the rationale dialog should be cancelable or not. Along with this option I also added options to provide text for the rationale dialog's buttons. I used this in my app to change the positive button to "Continue".