Skip to content

Conversation

@noahp
Copy link
Contributor

@noahp noahp commented Nov 26, 2025

Primarily to get new classifiers for showing supported python version on
PyPi (and in the badge in the readme here).

It's easy to verify this locally by using uvx to run versions of poetry to
build the .whl, and examine the wheel metadata:

❯ uvx --from=poetry==1.4.0 poetry -q build && unzip -q dist/nrfcloud_utils-*-py3-none-any.whl && rg 'Classifier: Programming Language :: Python' nrfcloud_utils-*.dist-info/METADATA && rm -rf nrfcloud_utils*
10:Classifier: Programming Language :: Python :: 3
11:Classifier: Programming Language :: Python :: 3.10
12:Classifier: Programming Language :: Python :: 3.11

❯ uvx --from=poetry==2.2.1 poetry -q build && unzip -q dist/nrfcloud_utils-*-py3-none-any.whl && rg 'Classifier: Programming Language :: Python' nrfcloud_utils-*.dist-info/METADATA && rm -rf nrfcloud_utils*
10:Classifier: Programming Language :: Python :: 3
11:Classifier: Programming Language :: Python :: 3.10
12:Classifier: Programming Language :: Python :: 3.11
13:Classifier: Programming Language :: Python :: 3.12
14:Classifier: Programming Language :: Python :: 3.13
15:Classifier: Programming Language :: Python :: 3.14

Primarily to get new classifiers for showing supported python version on
PyPi (and in the badge in the readme here).

It's easy to verify this locally by using `uvx` to run versions of poetry to
build the .whl, and examine the wheel metadata:

```bash
❯ uvx --from=poetry==1.4.0 poetry -q build && unzip -q dist/nrfcloud_utils-*-py3-none-any.whl && rg 'Classifier: Programming Language :: Python' nrfcloud_utils-*.dist-info/METADATA && rm -rf nrfcloud_utils*
10:Classifier: Programming Language :: Python :: 3
11:Classifier: Programming Language :: Python :: 3.10
12:Classifier: Programming Language :: Python :: 3.11

❯ uvx --from=poetry==2.2.1 poetry -q build && unzip -q dist/nrfcloud_utils-*-py3-none-any.whl && rg 'Classifier: Programming Language :: Python' nrfcloud_utils-*.dist-info/METADATA && rm -rf nrfcloud_utils*
10:Classifier: Programming Language :: Python :: 3
11:Classifier: Programming Language :: Python :: 3.10
12:Classifier: Programming Language :: Python :: 3.11
13:Classifier: Programming Language :: Python :: 3.12
14:Classifier: Programming Language :: Python :: 3.13
15:Classifier: Programming Language :: Python :: 3.14
```
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Poetry version used in CI workflows from 1.4.2 to 2.2.1, enabling newer Python version classifiers (3.12, 3.13, 3.14) to be displayed on PyPI. The update introduces a centralized POETRY_VERSION environment variable for consistent version management across all workflow jobs.

  • Centralizes Poetry version in a workflow-level environment variable
  • Updates Poetry from 1.4.2 to 2.2.1 in both build and publish jobs
  • Enables proper Python version classifiers for newer Python versions on PyPI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@maxd-nordic maxd-nordic merged commit 407fbe5 into main Dec 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants