Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 22 22
Lines 2734 2734
=======================================
Hits 2724 2724
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
## Rust linter (clippy) A recent update to rust's `clippy` tool triggered several lint violations when not targeting Linux. Some just required an explicitly anonymous lifetime for member functions that return buffer objects in the bindings. Others were about unused structs on non-Linux platforms in the node.js binding. The solution for this one was to conditionally compile the structs for only Linux targets. This is not considered a breaking change because the type info remains the same regardless. ## Pre-commit hooks Updated the pre-commit hooks and ran them ## Metadata Some metadata changes were made to exclude linting the rust examples by default. This was done because the examples do not compile for all platforms. More attention is still needed on this subject (see #8). To run the examples (still only on Linux), an extra arg is now required: `-p examples`. So, the command to run the getting-started example is now: ```shell cargo run -p examples --bin getting-started ``` These metadata changes also incited changes to the nurfile about various command invoked in tasks. ## CI workflows I adjusted the lint CI workflow to check all rust packages (including examples) in the workspace (this repo). I reviewed the caching of rust assets, which are only used when linting, testing, or documenting rust libraries.
2bndy5
force-pushed
the
fix-clippy-lints
branch
from
e92dffc to
2f16082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust linter (clippy)
A recent update to rust's
clippytool triggered several lint violations when not targeting Linux.Some just required an explicitly anonymous lifetime for member functions that return buffer objects in the bindings.
Others were about unused structs on non-Linux platforms in the node.js binding. The solution for this one was to conditionally compile the structs for only Linux targets. This is not considered a breaking change because the type info remains the same regardless.
Pre-commit hooks
Updated the pre-commit hooks and ran them
Metadata
Some metadata changes were made to exclude linting the rust examples by default. This was done because the examples do not compile for all platforms. More attention is still needed on this subject (see #8).
To run the examples (still only on Linux), an extra arg is now required:
-p examples. So, the command to run the getting-started example is now:These metadata changes also incited changes to the nurfile about various command invoked in tasks.
CI workflows
I adjusted the lint CI workflow to check all rust packages (including examples) in the workspace (this repo).
I reviewed the caching of rust assets, which are only used when linting, testing, or documenting rust libraries.