Merged
Conversation
- Uses [uv] to manage python dependencies and tools. - Added mypy to pre-commit hooks (and updated/ran them) - Created CONTRIBUTING.md doc - Reviewed nurfile [uv]: https://docs.astral.sh/uv/
2bndy5
added
documentation
2bndy5
force-pushed
the
switch-to-uv
branch
4 times, most recently
from
a8071ca to
1129bbe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 22 22
Lines 2734 2734
=======================================
Hits 2724 2724
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2bndy5
force-pushed
the
switch-to-uv
branch
2 times, most recently
from
ce1d415 to
b544faf
Compare
2bndy5
commented
Jul 31, 2025
| name = "rf24-py" | ||
| description = "A python package binding the nRF24/rf24-rs rust project." | ||
| requires-python = ">=3.8" | ||
| requires-python = ">=3.9" |
Member
Author
There was a problem hiding this comment.
I had to bump the minimum required python version because uv found a docs dependency that cannot support python v3.8.
Subsequently, I also updated the license metadata to adopt PEP639 which satisfies install-time warnings (see nRF24/pyRF24#105 for similar detail).
use `uvx pre-commit` without `uv sync`
in favor of inline `--with` arg
replaces some incoherent bash script and uses nurfile exports where applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypyto pre-commit hooks (and updated/ran them).