Conversation
|
Some platform support had to be removed due to the substantial changes to CI. The following failed to cross compile due to lack of adequate linker:
I added freeBSD platform support, but the CI (copied from napi-rs official template repo) uses a VM to build the node.js binding with rust v1.88 (as of this writing). From what I can tell, the CI doesn't use docker containers anymore. This was the blocker for upgrading bitfield-struct crate (which requires rust v1.83+ as of bitfield-struct v0.10.0) in the core rf24-rs dependencies. |
These are the necessary changes to the node.js bindings for napi-rs v3. This is mostly metadata and CI changes. Any deprecated rust API has been updated, but there is no breaking changes from a user perspective. - bump yarn to v4.9.2 - remove checked in bindings/node/npm folder; this is now generated in CI. - update coercion to boolean types from node.js number/boolean types. - update CI; based on napi-rs yarn template - bump npm dependencies and update yarn.lock - bump crates.io dependencies for bindings/node crate
in which cross-compilation env is missing the proper linker
does not change MSRV
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 22 22
Lines 2734 2734
=======================================
Hits 2724 2724
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These are the necessary changes to the node.js bindings for napi-rs v3.
This is mostly metadata and CI changes. Any deprecated rust API has been updated, but there is no breaking changes from a user perspective.