refactor!: replace open_tx_pipe() with as_tx(Option<address>)#41
Merged
refactor!: replace open_tx_pipe() with as_tx(Option<address>)#41
open_tx_pipe() with as_tx(Option<address>)#41Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 3175 3250 +75
=========================================
+ Hits 3175 3250 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This replaces the `open_tx_pipe()` by letting `as_tx()` accept an optional TX address. The intention is to satisfy a bug where using pipe 0 in RX mode prevents the TX address from being persistent when switch from RX to TX modes. Bug was raised in nRF24/RF24#1028. The solution is to cache the TX address internally, but this ended up invalidating the traditional order for radio setup. Removing `open_tx_pipe()` leaves less public API surface to cause problems.
adjust tests for - init() - with_config() - open_rx_pipe() - set_payload_length() reduce SPI transactions in with_config()
about RF24 C++ lib exposing the STATUS byte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the
open_tx_pipe()by lettingas_tx()accept an optional TX address.The intention is to satisfy a bug where using pipe 0 in RX mode prevents the TX address from being persistent when switch from RX to TX modes.
Bug was raised in nRF24/RF24#1028.
The solution is to cache the TX address internally, but this ended up invalidating the traditional order for radio setup. Removing
open_tx_pipe()leaves less public API surface to cause problems.