Add missing Confirm councils to client-side validation rules#5898
Merged
mysociety-pusher merged 2 commits intomasterfrom Mar 24, 2026
Merged
Add missing Confirm councils to client-side validation rules#5898mysociety-pusher merged 2 commits intomasterfrom
mysociety-pusher merged 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5898 +/- ##
==========================================
- Coverage 83.02% 83.01% -0.01%
==========================================
Files 465 465
Lines 36426 36427 +1
Branches 5975 5975
==========================================
- Hits 30243 30241 -2
- Misses 4438 4441 +3
Partials 1745 1745 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dracos
requested changes
Mar 20, 2026
Member
dracos
left a comment
There was a problem hiding this comment.
One query about Northamptonshire is all
…thants Replace the old Northamptonshire Highways entry with $.extend rules on North Northamptonshire Council and West Northamptonshire Council, giving both the 120-character title limit and the standard Confirm validation.
1de41e1 to
838ff13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a stuck Aberdeenshire report that had two phone numbers on the user, but Confirm only wants one.
There is server-side validation for long phone numbers, but it's skipped for reports created by staff members on behalf of someone else, which was the case for the stuck report.
fixmystreet/perllib/FixMyStreet/App/Controller/Report/New.pm
Lines 1477 to 1481 in 10d3d6a
Fix is to add in the missing client side validation. Have done this for the other councils that were obviously missing this.