Skip to content

[Sutton] Per container pricing - #5866

Merged
dracos merged 1 commit into
masterfrom
sutton-per-container-pricing
Mar 26, 2026
Merged

[Sutton] Per container pricing#5866
dracos merged 1 commit into
masterfrom
sutton-per-container-pricing

Conversation

@MorayMySoc

@MorayMySoc MorayMySoc commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Allow different containers to have different cost/admin charges

https://github.com/mysociety/societyworks/issues/5429

[skip changelog]

@MorayMySoc
MorayMySoc requested a review from struan February 26, 2026 11:24
@codecov

codecov Bot commented Feb 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.06%. Comparing base (61943c2) to head (8e56ac3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Sutton.pm 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5866      +/-   ##
==========================================
+ Coverage   83.04%   83.06%   +0.02%     
==========================================
  Files         465      465              
  Lines       36429    36431       +2     
  Branches     5975     5977       +2     
==========================================
+ Hits        30251    30260       +9     
+ Misses       4434     4430       -4     
+ Partials     1744     1741       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@struan struan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments but yup, looks good and works.

Comment thread perllib/FixMyStreet/Cobrand/Sutton.pm Outdated
Comment thread t/app/controller/waste_sutton_r.t Outdated
@struan
struan force-pushed the sutton-per-container-pricing branch from 83419ae to c88e89d Compare March 4, 2026 17:12
@dracos
dracos force-pushed the master branch 2 times, most recently from 72dc828 to 09633b0 Compare March 9, 2026 18:46
@struan
struan force-pushed the sutton-per-container-pricing branch from c88e89d to 628398c Compare March 12, 2026 15:05
@dracos
dracos force-pushed the sutton-per-container-pricing branch from 628398c to 8e56ac3 Compare March 26, 2026 14:34
Allow different containers to have different cost/admin charges,
including potentially different prices for moving larger/smaller.

No need to restrict the list in code any more as the configuration is
per container.

Co-Authored-By: Struan Donald <struan@mysociety.org>
@dracos
dracos force-pushed the sutton-per-container-pricing branch from 8e56ac3 to 71f01ba Compare March 26, 2026 16:48
@dracos
dracos merged commit 71f01ba into master Mar 26, 2026
21 checks passed
@dracos
dracos temporarily deployed to github-pages March 26, 2026 16:50 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants